search

ATTPC / Spyral

A Python analysis library for AT-TPC data
GNU General Public License v3.0
2 stars 2 forks source link

GetEvent should not expect an HDF5 dataset #178

Closed gwm17 closed 1 month ago

gwm17 commented 1 month ago

GetEvent expects an HDF5 dataset as input when it probably should just take in a numpy array. No real reason why we do this and this will break the conduit who of course doesn't receive HDF5 data. Probably worth looking at a refactor for GetEvent and friends, its been a while since we've gone deep and refactored that code.

gwm17 commented 1 month ago

Done. Waiting for testing and merging