ATell-SoundTheory / CliffordAlgebras.jl

A fast and lightweight Julia package for Clifford and geometric algebras.
https://atell-soundtheory.github.io/CliffordAlgebras.jl/
MIT License
36 stars 4 forks source link

Expanded coefficients and Added broadcasting for * and / #17

Open Vizia128 opened 1 year ago

Vizia128 commented 1 year ago

Added broadcasting to allow for inertial maps in PGA physics.

Base.broadcasted(::typeof(*), a::MultiVector, b::MultiVector)::MultiVector
Base.broadcasted(::typeof(/), a::MultiVector, b::MultiVector)::MultiVector

Added the ability to grab a tuple or vector of coefficients from a MultiVector. This allows for grabbing the coefficients of a sub algebra.

coefficients(mv::MultiVector, idxs::Union{NTuple, AbstractVector})

Fixed a bug where isapprox(0alg.e1, 0alg.e1) returns false.

ATell-SoundTheory commented 1 year ago

Thank you very much for your contribution. I've done a quick code review and I have a few minor issues:

If you address these issues there shouldn't be anything in the way of merging your changes.

Vizia128 commented 1 year ago

Thank you for the feedback. I think I have addressed the issues.