Open Vizia128 opened 1 year ago
Thank you very much for your contribution. I've done a quick code review and I have a few minor issues:
coefficient
, but the code says coefficients
.coefficient
function you're generalizing handles both, you should, too. You are also relying on more internals than you have to. You should probably just forward the array/tuple to the already defined coefficient functions with a map.If you address these issues there shouldn't be anything in the way of merging your changes.
Thank you for the feedback. I think I have addressed the issues.
coefficients
to be pluralcoefficients
Added broadcasting to allow for inertial maps in PGA physics.
Added the ability to grab a tuple or vector of coefficients from a MultiVector. This allows for grabbing the coefficients of a sub algebra.
Fixed a bug where isapprox(0alg.e1, 0alg.e1) returns false.