search

AThilenius / scorchforge

The private rebuild of the Scorch project
0 stars 0 forks source link

Form update #5

Closed skycoop closed 8 years ago

skycoop commented 8 years ago

It's essentially at the same place it was before, but maybe a little bit cleaner on the implementation side, since formly is much more powerful and only takes 3 lines of HTML

AThilenius commented 8 years ago

Am I reading something wrong or are the .html file changes missing? Also can app.run(...) for Formly stuff be moved to the login_controller.js / create_user_controller.js? Angular is super modular, it doesn't really care where/when you register things.

skycoop commented 8 years ago

I have no idea where those changes are. As far as the registration, I put it there because those are global configs that will affect any form we decide to make in the future so it seemed appropriate to put it in the main app file

AThilenius commented 8 years ago

Ahh, got it. All your changes are still in the repo, https://github.com/AThilenius/scorchforge/commit/85b0d87c0f71e0ff599526b8c0cbaf507d2fa0e0 The HTML stuff is there too. I just got jscs set up, it's way better! Once this merge goes through I'll reformat all files.

skycoop commented 8 years ago

Cool. Sounds good

On Fri, Jan 22, 2016 at 4:30 PM Alec Thilenius notifications@github.com wrote:

Ahh, got it. All your changes are still in the repo, 85b0d87 https://github.com/AThilenius/scorchforge/commit/85b0d87c0f71e0ff599526b8c0cbaf507d2fa0e0 The HTML stuff is there too. I just got jscs set up, it's way better! Once this merge goes through I'll reformat all files.

— Reply to this email directly or view it on GitHub https://github.com/AThilenius/scorchforge/pull/5#issuecomment-174086242.

AThilenius commented 8 years ago

Do you want to throw the HTML stuff in with this though?

skycoop commented 8 years ago

Yeah. Let me close this one an open a new one

skycoop commented 8 years ago

So that commit with the HTML is already on master, so we'd just need to pull in the JavaScript

AThilenius commented 8 years ago

No I rolled back that commit in https://github.com/AThilenius/scorchforge/commit/6fd0f257049afa5c1c8b4ef008a09c044d0e4a57 Everything rolled back from that you want needs to go back in.