ATrappmann / PN5180-Library

PN5180 library for Arduino
GNU Lesser General Public License v2.1
104 stars 92 forks source link

Issue in library for locking SLIX2 #42

Closed Nettermann90 closed 2 years ago

Nettermann90 commented 2 years ago

There is an Issue in the Enable Privacy on SLIX2 Tags.

In file: PN5180ISO15693.cpp

function: ISO15693ErrorCode PN5180ISO15693::enablePrivacy(uint8_t password, uint8_t random)

you need to replace the line: uint8_t setPrivacy[] = {0x02, 0xBA, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};

with: uint8_t setPrivacy[] = {0x02, 0xBA, 0x04, 0x00, 0x00, 0x00, 0x00};

there are two bytes to much, with the origianl code it will not work.

Best Regards, Felix

tueddy commented 2 years ago

You're right! It's already fixed in this fork: https://github.com/tueddy/PN5180-Library/blob/master/PN5180ISO15693.cpp

grafik

ATrappmann commented 2 years ago

Thanks for the information. I will fix it asap. --Andreas.

-----Original-Nachricht----- Betreff: Re: [ATrappmann/PN5180-Library] Issue in library for locking SLIX2 (#42) Datum: 2021-08-18T11:59:38+0200 Von: "tueddy" @.> An: "ATrappmann/PN5180-Library" @.>

You're right! It's already fixed in this fork: https://github.com/tueddy/PN5180-Library/blob/master/PN5180ISO15693.cpp [grafik] https://user-images.githubusercontent.com/11274319/129878070-c4e1e3e2-682f-4a2c-ac78-1280b6d2b3c9.png — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ATrappmann/PN5180-Library/issues/42#issuecomment-900983697 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVOSHT3K7A4PZS4RYZBEJTT5OAAJANCNFSM5CLTDIFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email . [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/ATrappmann/PN5180-Library/issues/42#issuecomment-900983697", "url": "https://github.com/ATrappmann/PN5180-Library/issues/42#issuecomment-900983697", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ] 

ATrappmann commented 2 years ago

Fixed in Version 1.8