Remove grz_pars

[sashahafner]

@fdalby are these parameters still used in abm()? I see this around L 230 in abm.R

  # calculate grazing interval of year if needed
  if(pars$graze_days > 0){
    pars$graze_int <- c(doy(pars$graze_start, 'March')$day, doy(pars$graze_start, 'March')$day + pars$graze_days)
  } else {
    pars$graze_int <- 0
  }

But I don't see "graze" in abm_*.R files. If we do still need it is the hard-wired 'March' a problem?

[fdalby]

@fdalby are these parameters still used in abm()? I see this around L 230 in abm.R

  # calculate grazing interval of year if needed
  if(pars$graze_days > 0){
    pars$graze_int <- c(doy(pars$graze_start, 'March')$day, doy(pars$graze_start, 'March')$day + pars$graze_days)
  } else {
    pars$graze_int <- 0
  }

But I don't see "graze" in abm_*.R files. If we do still need it is the hard-wired 'March' a problem?

graze is in rates.R, I am using it for the abm carbon accounting stuff and would like to keep it. At least can we keep it as is until/or if I find a better solution?

[sashahafner]

Ah, OK. Sure, no problem to keep it. Does that hard-wired 'March' need to be changed though? I am not sure what the code does so it might be fine.

[sashahafner]

Hmm, does it make sense to put grazing information in the "management" parameter argument? Not sure.

[fdalby]

Hmm, does it make sense to put grazing information in the "management" parameter argument? Not sure Yes seems right to move to mng_pars. I will also remove the 'March'

[sashahafner]

OK, good, I see you already moved it. Either in the help file or vignette could you explain the timing @fdalby ? I don't remember how the grazing date works when the other timing info is all relative (just days, not date).

[fdalby]

OK, good, I see you already moved it. Either in the help file or vignette could you explain the timing @fdalby ? I don't remember how the grazing date works when the other timing info is all relative (just days, not date).

@sashahafner Sure. So be default it has reference to 1. January now. The only time when it is relevant is when grazing is used along with outside variable temperature. The outside temperature which is as ".rda" file also starts from January 1. I will add the info to the help file.

[fdalby]

Then

I will add the info to the help file.

Now added around L67

[fdalby]

Done