AU-BCE-EE / tric-fil-mod

A trickling filter model to simulate air treatment, written in Python
GNU General Public License v3.0
0 stars 0 forks source link

Add liquid flow #8

Closed sashahafner closed 1 year ago

sashahafner commented 1 year ago

Done now around a4a1875d9c89c560c1c72eca7a6127d3c95ba35b

sashahafner commented 1 year ago

But note that incoming liquid has compound concentration of 0 hardwired in (see cvec vars below, compare gas and liquid):

    # Gas phase derivatives (g/s)
    # No reaction in gas phase
    # cddiff = concentration double difference (g/m3)
    # cvec = array of cell concentrations with inlet air added
    cvec = np.insert(ccg, 0, cgin)
    advec = - v_g * np.diff(cvec)
    dmg = advec - g2l

    # Liquid phase derivatives (g/s)
    # Includes transport and reaction
    rxn = k * mcl
    # NTS: where does liquid come from? Right now assumed to be pure with 0 below
    cvec = np.insert(ccl, 0, 0)
    advec = - v_l * np.diff(cvec)
    dml = advec + g2l - rxn

I guess this should be a function argument instead, right @afeilberg ?

afeilberg commented 1 year ago

To start with liquid can be assumed to not be recirculated or the contaminant concentration is assumed 0 when recirculated, but there may of course be cases with recirculation where the concentration is in fact not 0, which adds a level of complexity...

Not clear if it should be a function argument to be honest

sashahafner commented 1 year ago

OK, I'm leaving it hard-wired as 0 for now. We could make it an argument later, and should be able to add recirculation too.

sashahafner commented 1 year ago

f41f9dbb0fb1fab984e6deb5513ee4d22756c707 has clin