AU-ExoMars / PCOT

Pancam Operations Toolkit
MIT License
3 stars 0 forks source link

Undo redo (again) - deleted/undone nodes can't be reopened #41

Closed jimfinnis closed 2 years ago

jimfinnis commented 2 years ago
jimfinnis commented 2 years ago

Perhaps it's this:

Looks like that's it - openTab scans the tabs (a bit inefficient, that) and finds a tab is still there in node.tabs.

So how does undo work when it comes to restoring deleted nodes? Or rather, should delete remove a node's tabs? That won't work because the mark is done before the remove; we're still recording that the node has tabs.

Hm.. the bug is earlier; I don't think that deleting a node (which closes its tabs) removes the tab from mainwindow's dict. It seems that closing a tab when a node is deleted isn't done using the normal method (calling closeTab on the window).

jimfinnis commented 2 years ago

Fixed in ae001d84ec9dbb476479f2331b1cdba928ddadb7