MACROS ARE BROKEN: Macros with expr nodes fail

AU-ExoMars / PCOT

Pancam Operations Toolkit

MIT License

3 stars 0 forks source link

MACROS ARE BROKEN: Macros with expr nodes fail #59

Closed jimfinnis closed 1 year ago

jimfinnis commented 1 year ago

Create a macro with input->expr->output dealing with numbers
Save it, seems ok.
Load it, no longer ok - it thinks the numeric type going into the output is actually ANY.

I think this is due to the new dynamic type system on expr outputs (we call node.setOutputType in the node's perform).

Fixing this will require some thought, but it needs doing if we ever want macros to work.

jimfinnis commented 1 year ago

This should be fixed now that connection types are effectively advisory; disconnections aren't forced when the type is wrong but the connection line will be red (as per Issue #60 )