AURAPluginsLtd / Access-Virus-Editor

Issue & Request tracking, Community Discussion, Wiki and "Future Release" Project Boards for Access Virus Editor & Librarian users
https://auraplugins.com/product/access-virus-editor/
8 stars 0 forks source link

VirusHE Not receiving to single part dumps from Virus #37

Open Guod3 opened 1 year ago

Guod3 commented 1 year ago

VirusHE is not processing a "single part dump" from the Virus

Describe the bug When an externally originated single part dump request is made to the virus synth, the synth responds (as it should) with a "Single Dump" as documented in Virus C OS5 Manual English.pdf page 160 The GUI does not update to reflect the data transmitted by the synth (which has been modified with external CC messages).

To Reproduce Steps to reproduce the behaviour:

  1. Synth is connected to midi port in usual way. The port interface driver needs to be multi client so that you can inject messages to, and monitor messages from the Virus HW at the same time as VirusHE.
  2. Activate MIDI OX with the same midi port selected for input. Open a midi monitor window to see all data out of the virus.
  3. Send the virus CC 40 and 41 (for example) externally to change the virus audibly (and visually on LCD).
  4. Issue (externally) a standard part single dump request before and after changing the CC's
  5. Note the data in MIDI OX of the sysex dump in positions 40 and 41 changes as it should.

Expected behavior I expect (and hope) that all data internal and GUI would be updated by a Single Dump from the synth. If this is by design or omission I would certainly like to have this as a feature request ! Thanks

JaniKervinen commented 1 year ago

@Guod3 do you mean you want to execute single dump from virus and software should respond to it automatically?

Guod3 commented 1 year ago

I'm sending a single dump request to the virus, which is responding by transmitting the single dump, but VirusHE is not using the data to update its state. VirusHE responds to received CC and Sysex parameter change as it must to stay in sync with changes made on the hw UI, but appears to ignore the single dump. It would very useful if it did (or does)... I could post the hex request and dump messages if that helps...

JaniKervinen commented 1 year ago

Generally editor only accepts requests IF it is made from the editor itself. Now that next update comes available, single dump can be requested with the editor "sync data from hw" button next to the control display area.

Processing the single dump every time it comes in, randomly, would cause serious CPU spikes unless user is not aware of what's happening.

We will keep it that way to though to keep down "bug" reports of audio device spikes and CPU usage spikes etc. I hope you understand our perspective.

Guod3 commented 1 year ago

Single part sync from the GUI will be great to have IMO, so that's good news. I totally understand your need to minimise support requests where there are risks for new users. I would have thought dump requests are hard to happen randomly or by accident, however.

Anyhow, I have issued Controller Dump Request instead of Single Dump and VirusHE handles this well! This largely satisfies my want for a way of using external controllers all data staying in sync and total recall. The only imperfection with this is that Controller Dumps do not contain the parameters of the part name text, so that the VirusHE part name list remains un-updated...

Guod3 commented 1 year ago

I just tested the sysex short message parameter change for page B, address 0x70 to 0x79 for name text. The Virus responds as expected, but VirusHE does not update the part name. The feature request would be if it could update the part name text with the sysex short msg lake all the other parameters already do.