AUTOMATIC1111 / stable-diffusion-webui-extensions

Extension index for stable-diffusion-webui
505 stars 266 forks source link

Add Characteristic_Guidance_Web_UI.json #253

Closed scraed closed 10 months ago

scraed commented 10 months ago

Characteristic_Guidance_Web_UI

New guidance method providing large CFG scale correction for classifier-free guidance. Compatible with existing sampling methods.

Info

Checklist:

w-e-w commented 10 months ago

hi sorry took awhile for me to start merging extension to index

I have tested your extension and it does work so it can be added but there are some issues that I will prefer that you sorted out before it gets merged I've sent over a PR with explanations https://github.com/scraed/CharacteristicGuidanceWebUI/pull/1

basically if you merge my PR that you should be solved but please check my PR aligns with your ideals and verify the functionality does work before you merge it

w-e-w commented 10 months ago

I remove tab extras tag and added science seems more fitting see https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions/blob/extensions/tags.json

w-e-w commented 10 months ago

@scraed nice I see you have made some changes the keys names used https://github.com/scraed/CharacteristicGuidanceWebUI/commit/3188027f30123ffd1f4df1302873e5ab28d80f77

are the key names final I want to confirm because it's better that you finalize them before I merge this into index

scraed commented 10 months ago

@w-e-w Yes, I have merged the PR to fix the infotext issue with some name changes. I think they are final. Thanks again for your PR!

w-e-w commented 10 months ago

great