AUTOMATIC1111 / stable-diffusion-webui-extensions

Extension index for stable-diffusion-webui
504 stars 266 forks source link

changing to fork with more up-to-date scripts #312

Closed gutris1 closed 6 months ago

gutris1 commented 6 months ago

Repo

w-e-w commented 6 months ago

@NoCrypt

light-and-ray commented 6 months ago

Hmm, does curl program exist on windows? In install.py it is used. Maybe it's better to use urllib.request.urlretrieve(url, outPath) for compatibility

CapsAdmin commented 6 months ago

Hmm, does curl program exist on windows? In install.py it is used. Maybe it's better to use urllib.request.urlretrieve(url, outPath) for compatibility

https://curl.se/windows/microsoft.html

Yeah, since around windows 10. Whether or not that means you should use it is something else. I'd say if you're in python already, just use python.

gutris1 commented 6 months ago

oops I didn't even think about Windows, fixed now thanks guys

gutris1 commented 6 months ago

closing this as I've lost interest.

w-e-w commented 6 months ago

just so you know when possible we don't like to change the url of a extension on the index the reason being changing the URL only changes it for new installations and based on NoCrypt account activity he is still active just last week so in this case it's best to be contact the original repository


NoCrypt just replyed https://github.com/NoCrypt/sd-fast-pnginfo/pull/9#issuecomment-2103921649

gutris1 commented 6 months ago

just so you know when possible we don't like to change the url of a extension on the index the reason being changing the URL only changes it for new installations and based on NoCrypt account activity he is still active just last week so in this case it's best to be contact the original repository

NoCrypt just replyed NoCrypt/sd-fast-pnginfo#9 (comment)

I understand that, that's why Im closing this PR Thank you.