AUTOMATIC1111 / stable-diffusion-webui-extensions

Extension index for stable-diffusion-webui
483 stars 261 forks source link

Add sd-webui-udav2 #334

Closed MackinationsAi closed 2 months ago

MackinationsAi commented 2 months ago

Info

sd-webui-udav2

Checklist:

w-e-w commented 2 months ago

I've tested extension and it works this extension can be merged at any time but if possible I like to make some basic improvements to the code before it gets pushed to the masses

MackinationsAi commented 2 months ago

I accepted & merged the changes you made. Thanks! If you approve please push to the masses.

w-e-w commented 2 months ago

one thing your tags doesn't really match the original definition

yeah I think the category is kind of outdated but still ....

https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions/blob/cfe860a840ff2006638731a77d1aa9024c7ebaea/tags.json#L2-L18

as far as I can say your extension currently is a tab that does extra performs depth estimation on images / videos

tab is correct

but it is not "models": "conversion and merging related." completely unrelated

"manipulations": "an extension that changes images with stable diffusion." typically refers to extensions that are integrated into the SD pipeline and that does changes that are related to stable diffusion prime example control net your extension is a standalone tab that adds extra functionality

"editing": "an extension that changes images, not using stable diffusion.", similer to manipulations, but does its operation based on non-state diffusion methods such as such as super resolution upscaling

"extras": "adds new functionality to the extras tab." your extension does not add a module to extra tab


animation is loosely okay as your outfit can be used for video -> depth -> animation stuff


so I'm going to modify this to only these two tags

    "tags": [
        "tab",
        "animation",
    ]