AUTOMATIC1111 / stable-diffusion-webui-extensions

Extension index for stable-diffusion-webui
502 stars 266 forks source link

sd-all-prompt-wildcards #357

Closed MackinationsAi closed 3 months ago

MackinationsAi commented 3 months ago

Info

Allows the user to use wildcards in both the positive & negative prompt sd-all-prompt-wildcards.

Checklist:

w-e-w commented 3 months ago

let me ask AUTO why he didn't merge

if possible we can get him to update the extension

MackinationsAi commented 3 months ago

Sounds good, just got tired of waiting so made my own version, also someone on reddit informed me that sd-dynamic-prompting supports negative wildcards so it's not a big deal, hadn't used dynamic-prompting in a while & didn't know. Appreciate the quick response w-e-w!

w-e-w commented 3 months ago

ATUO has updated the extention for negative prompt https://github.com/AUTOMATIC1111/stable-diffusion-webui-wildcards/commit/d2c836bc2d40d3ad170ac7d8a91fec77e5557af6

note there is a slite issue but I made a PR to fix that


by the way for future reference basically it's not a good idea to make changes on the main branch

I believe the best practice is to:

  1. sync main branch then
  2. make a new branch of the synced main branch
  3. make your changes on this new branch
  4. PR this new branch

otherwise you might get merge conflicts like these https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions/pull/357/conflicts