search

AUTOMATIC1111 / stable-diffusion-webui-wildcards

Wildcards
428 stars 104 forks source link

[Possible PR] Wildcards ported from outdated script #5

Open aphix opened 1 year ago

aphix commented 1 year ago

Looks like this script didn't bring over the updates I made to the existing wildcard script that handled image grid generation as a final step, fixed seed issues, and added wildcard prompt info to the PNG metadata.

If those aren't something to be handled by extensions anymore then perhaps this can be closed, but otherwise these two commits should be simple enough to port to the new script. Let me know if you'd prefer if I submitted as a PR, or if there was a reason the outdated script was used (these were previously already merged into the jtkelm2 script).

https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/8969bb493b9a87f00a315ef80f3032f017d179da https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/5a4a343fa557bcbd0cf5a7b9eb8426e74518bbb4 (note that the 2nd commit fixes a few issues noticed/mentioned when developing 1st commit)

Thanks, Aphix

mnielsendev commented 1 year ago

I'd also like to see this extension caught up to the existing wildcard script. If AUTOMATIC1111 (understandably) doesn't want to maintain this extension on top of everything else then it might be good idea to hand it over to the creator of the original script or whoever wants to update and maintain wildcards.

Edit: Upon further research, I'm a bit confused. Has the Wildcards extension been superseded by Dynamic Prompts? If so, it might be good if the former were dropped from the WebUI extensions list. Also apologies for any accidental automatic pings if this is indeed a necropost.