AUTOMATIC1111 / stable-diffusion-webui

Stable Diffusion web UI
GNU Affero General Public License v3.0
131.71k stars 25.28k forks source link

dont send server address in a-href #15631

Open light-and-ray opened 3 weeks ago

light-and-ray commented 3 weeks ago

Description

Gradio sets these tags automatically when generates hyperlinks from markdown rel="noopener noreferrer" I've added them into webui's html

You can see users' non-local server addresses (e.g. --share or their hosting) in github's repo statistics for example, when they go to the repo via Extensions tab. Other sites can see them too. This PR fixes this

Checklist:

w-e-w commented 3 weeks ago

I think it might be possible to just set Referrer-Policy header no-referrer to automatically apply to the entire web page https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy

w-e-w commented 3 weeks ago
light-and-ray commented 3 weeks ago

I thinks it's good to merge both

w-e-w commented 3 weeks ago

I thinks it's good to merge both

in my opinion if the global one works then just the global one is better less clutter the the code