[Bug]: Out of memory while using Upscaler

AUTOMATIC1111 / stable-diffusion-webui

Stable Diffusion web UI

GNU Affero General Public License v3.0

136.77k stars 26.04k forks source link

[Bug]: Out of memory while using Upscaler #16181

Open RoyalXXX opened 2 weeks ago

RoyalXXX commented 2 weeks ago

Checklist

[ ] The issue exists after disabling all extensions
[X] The issue exists on a clean installation of webui
[ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
[X] The issue exists in the current version of the webui
[ ] The issue has not been reported before recently
[ ] The issue has been reported before but has not been fixed yet

What happened?

Upscaling the image with R-ESRGAN 4x+ (512x512 to 2048x2048) in Hires.fix tab consumes more than 32 GB of memory. Just don't give me the nonsense that this operation needs that much memory. Looks like there's some kind of memory leak in the webui. So much memory is not consumed when upscaling an image in Extras tab.

Steps to reproduce the problem

What should have happened?

What browsers do you use to access the UI ?

Microsoft Edge

Sysinfo

Console logs

Additional information

No response

w-e-w commented 2 weeks ago

from what you have written here I don't even know what version of webui you are using if you want us to have a chance to fixing stuff like this you need to at least provide the basic information that we asked for

RoyalXXX commented 2 weeks ago

"Platform": "Windows-10-10.0.22631-SP0", "Python": "3.10.6", "Version": "v1.9.4", "Commit": "feee37d75f1b168768014e4634dcb156ee649c05", "Commandline": [ "launch.py", "--use-cpu", "all", "--precision", "full", "--no-half", "--skip-torch-cuda-test" ],

RoyalXXX commented 2 weeks ago

It seems to me that the Hires.fix isn't just an Upscaler. I mean that this bug could be explained only by assuming that other complex calculations besides image upscaling take place when Hires.fix is running. Even if this is the case, you need to change the description of this operation on the Hires.fix tab. Because, right now from the description, it seems that this tab just starts the Upscaler after the image is generated. I'm making this assumption based on the fact that upscaling an image in Extras tab with the same settings requires almost no RAM. Regarding providing information, I believe the information you are requesting is excessive and not reasonable given my particular situation. The file you are requesting contains a lot of personal data that can't help you in any way to solve the problem. I've already pointed out that:

The issue exists on a clean installation of webui
The issue exists in the current version of the webui

highnrgappalachian commented 2 weeks ago

Massive PEBKAC.

RoyalXXX commented 2 weeks ago

Massive PEBKAC.

If this is even the case, the problem is that the UI is misleading. Capture d'écran 2024-07-13 143044 From the description as well as the controls of this tab, the user gets the feeling that this feature only activates the Upscaler.

highnrgappalachian commented 1 week ago

The only problem here is that you downloaded a software that has been out for a long time and decided to report something as a software issue when you obviously haven't read a single letter from the documentation, alerting the devs to a potential issue.

https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Features#hires-fix

Don't bloat the software's Issues page with your personal problems of reading comprehension, this is used to track legitimate problems.