[Bug]: --disable-console-progressbars is ignored regarding console task progressbars

[Glen-O]

Is there an existing issue for this?

• [X] I have searched the existing issues and checked the recent builds/commits

What happened?

Using --disable-console-progressbars does not turn off console progressbars for individual tasks - it only turns off total progress progressbars, for which a Setting already exists

Steps to reproduce the problem

1. Set --disable-console-progressbars
2. Run a task that would normally print a progress bar to console
3. Watch as the progress bar appears.

What should have happened?

No progress bar should have appeared

Commit where the problem happens

9cfd10cdefc7b2966b8e42fbb0e05735967cf87b

What platforms do you use to access UI ?

Linux

What browsers do you use to access the UI ?

Mozilla Firefox

Command Line Arguments

--disable-console-progressbars --lowvram --use-cpu interrogate --xformers --opt-channelslast

Additional information, context and logs

I believe the fault lies in sd_samplers.py, where it says "disable=False" near the end of both sample() and sample_img2img(), which means it's hard-coded for the progressbars to appear. Changing these to "disable=cmd_opts.disable_console_progressbars" makes it work as expected... however, since there's already a Setting for the total progress progressbar, perhaps it's worth moving this to a setting as well, rather than being a command line argument?

[InResponse]

I just noticed the same issue myself, as it becomes relevant when running as a systemd service. The system journal gets bloated with lines like

May 13 11:11:11 stable-diffusion-webui webui.sh[9876]: [123.45K blob data]

It appears that the functions @Glen-O mentioned are actually in sd_samples_kdiffusion.py. Setting disable=True does disable the progress bar, but cmd_opts isn't accessible from there.

[jangrewe]

I'm having the same problem, my systemd log is full of this:

May 20 02:08:44 hades docker[1095829]: [869B blob data]
May 20 02:08:44 hades docker[1095829]: Running DDIM Sampling with 29 timesteps
May 20 02:08:51 hades docker[1095829]: [2.2K blob data]
May 20 02:09:21 hades docker[1095829]: [869B blob data]
May 20 02:09:21 hades docker[1095829]: Running DDIM Sampling with 29 timesteps
May 20 02:09:27 hades docker[1095829]: [2.2K blob data]
May 20 02:09:42 hades docker[1095829]: [869B blob data]
May 20 02:10:12 hades docker[1095829]: [753B blob data]
May 20 02:10:12 hades docker[1095829]: Running DDIM Sampling with 24 timesteps
May 20 02:10:18 hades docker[1095829]: [1.8K blob data]
May 20 02:11:53 hades docker[1095829]: [753B blob data]
May 20 02:11:53 hades docker[1095829]: [94B blob data]
May 20 02:11:59 hades docker[1095829]: [1.8K blob data]

The original commit for this: https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/3ff0de2c594b786ef948a89efb1814c59bb42117

[iotkaden20230322]

Me too