search

AUTOMATIC1111 / stable-diffusion-webui

Stable Diffusion web UI
GNU Affero General Public License v3.0
139.23k stars 26.42k forks source link

[Bug]: Close button on "Show Extra networks"not displaying after latest update #8559

Closed Aamir3d closed 1 year ago

Aamir3d commented 1 year ago

Is there an existing issue for this?

What happened?

Before the last update, on clicking the "show extra networks" button here image used to display a close button, which was very useful. image

After updating to commit: [27eedb69], the button has vanished. Can this be brought back please? It is very useful when adding Loras or hypernetworks

image

Steps to reproduce the problem

  1. Go to .... img2img tab
  2. Press .... "Show extra networks" button
  3. ... Click any tab in the networks

What should have happened?

The Close button should display

Commit where the problem happens

https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/27eedb696661d031b9a7b8641b50eaec8dabf64f

What platforms do you use to access the UI ?

Windows

What browsers do you use to access the UI ?

Google Chrome

Command Line Arguments

--xformers --ckpt-dir O:\SD LOCAL\Models --lora-dir O:\SD LOCAL\Lora --hypernetwork-dir O:\SD LOCAL\Hypernetwork --administrator

List of extensions

Extension URL Version ABG_extension https://github.com/KutsuyaYuki/ABG_extension.git e64ea765 (Sat Feb 25 18:27:03 2023) Hypernetwork-MonkeyPatch-Extension https://github.com/aria1th/Hypernetwork-MonkeyPatch-Extension.git c3ada0ee (Mon Feb 27 16:53:53 2023) animator_extension https://github.com/Animator-Anon/animator_extension e8bff436 (Thu Feb 16 09:49:04 2023) clip-interrogator-ext https://github.com/pharmapsychotic/clip-interrogator-ext.git e2f7b7f2 (Wed Mar 1 05:11:13 2023) deforum-for-automatic1111-webui https://github.com/deforum-art/deforum-for-automatic1111-webui.git 09c99d10 (Sat Mar 4 20:01:06 2023) depth-image-io-for-SDWebui https://github.com/AnonymousCervine/depth-image-io-for-SDWebui.git eb22863d (Sat Feb 4 06:52:38 2023) depthmap2mask https://github.com/Extraltodeus/depthmap2mask.git 3c1874f5 (Wed Dec 7 02:40:16 2022) embedding-inspector https://github.com/tkalayci71/embedding-inspector.git 4ed06419 (Sat Feb 25 11:17:37 2023) multi-subject-render https://github.com/Extraltodeus/multi-subject-render.git 1d8689ab (Tue Feb 28 12:39:09 2023) openpose-editor https://github.com/fkunn1326/openpose-editor.git 08ad9334 (Wed Mar 1 23:15:27 2023) sd-dynamic-prompts https://github.com/adieyal/sd-dynamic-prompts b09f4b7c (Mon Feb 27 10:12:27 2023) sd-web-ui-quickcss https://github.com/Gerschel/sd-web-ui-quickcss.git 53fe5a86 (Sat Jan 28 21:19:33 2023) sd-webui-additional-networks https://github.com/kohya-ss/sd-webui-additional-networks.git 822f2136 (Thu Feb 16 12:57:55 2023) sd-webui-ar https://github.com/alemelis/sd-webui-ar.git ce0a645c (Thu Feb 23 13:59:23 2023) sd-webui-controlnet https://github.com/Mikubill/sd-webui-controlnet 4c13542c (Sun Mar 12 11:14:08 2023) sd-webui-model-converter https://github.com/Akegarasu/sd-webui-model-converter 7a998ede (Wed Feb 8 14:16:16 2023) sd-webui-multiple-hypernetworks https://github.com/antis0007/sd-webui-multiple-hypernetworks.git dc37ce84 (Tue Jan 10 06:48:35 2023) sd-webui-supermerger https://github.com/hako-mikan/sd-webui-supermerger.git 7906592c (Thu Mar 2 10:07:19 2023) sd_delete_button https://github.com/AlUlkesh/sd_delete_button e42f8ac9 (Sat Mar 11 22:58:20 2023) sd_dreambooth_extension https://github.com/d8ahazard/sd_dreambooth_extension d4e2f7d5 (Wed Mar 1 03:01:13 2023) sd_save_intermediate_images https://github.com/AlUlkesh/sd_save_intermediate_images 5f2af477 (Sun Feb 26 23:22:45 2023) sdweb-merge-block-weighted-gui https://github.com/bbc-mc/sdweb-merge-block-weighted-gui 8a62a753 (Thu Jan 19 21:31:06 2023) stable-diffusion-webui-Prompt_Generator https://github.com/imrayya/stable-diffusion-webui-Prompt_Generator 1e7a6f92 (Sat Feb 11 11:10:47 2023) stable-diffusion-webui-aesthetic-gradients https://github.com/AUTOMATIC1111/stable-diffusion-webui-aesthetic-gradients 2624e5dd (Fri Jan 6 10:59:30 2023) stable-diffusion-webui-composable-lora https://github.com/opparco/stable-diffusion-webui-composable-lora.git d4963e48 (Mon Feb 27 17:40:08 2023) stable-diffusion-webui-dataset-tag-editor https://github.com/toshiaki1729/stable-diffusion-webui-dataset-tag-editor 8f1f045e (Tue Feb 28 10:27:40 2023) stable-diffusion-webui-depthmap-script https://github.com/thygate/stable-diffusion-webui-depthmap-script.git 189e30ad (Mon Feb 6 12:13:59 2023) stable-diffusion-webui-images-browser https://github.com/AlUlkesh/stable-diffusion-webui-images-browser.git ed8c24cf (Sun Mar 12 07:20:09 2023) stable-diffusion-webui-model-toolkit https://github.com/arenatemp/stable-diffusion-webui-model-toolkit 8d8f073f (Fri Feb 17 20:39:41 2023) stable-diffusion-webui-two-shot https://github.com/opparco/stable-diffusion-webui-two-shot.git 9936c52e (Sun Feb 19 08:40:41 2023) stable-diffusion-webui-wd14-tagger https://github.com/toriato/stable-diffusion-webui-wd14-tagger.git 590c9a73 (Sun Feb 19 11:51:48 2023) ultimate-upscale-for-automatic1111 https://github.com/Coyote-A/ultimate-upscale-for-automatic1111.git 0a3d03a4 (Tue Feb 7 06:07:23 2023) LDSR built-in
Lora built-in
ScuNET built-in
SwinIR built-in
prompt-bracket-checker built-in

Console logs

No errors

Additional information

No response

Soulreaver90 commented 1 year ago

It was, for whatever reason, removed as part of #7965

FartyPants commented 1 year ago

It's apparently not a bug but feature... go figure out https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/7965/commits/247a34498b337798a371d69483bbcab49b5c320c

Aamir3d commented 1 year ago

I have no idea why the close button would be removed. Refresh is understandable, if I add a new Lora and click Refresh, it shows in the extra networks tab, but not having the Close button next to it is a pain. If you have more than 80 Loras, it's challenging scrolling to the bottom without the utility of the "Close" button.

Kilvoctu commented 1 year ago

Sorry, I guess you can blame me. That said, the 🎴 icon is a toggle; it opens as well as closes the window.
I should have updated the tooltip too.

Aamir3d commented 1 year ago

Sorry, I guess you can blame me. That said, the 🎴 icon is a toggle; it opens as well as closes the window. I should have updated the tooltip too.

Nothing to be sorry about - you're contributing. I didn't even know this was a toggle ... for months now (Non developer here, and the "Close" button UI functionality is ingrained in a lot of people vs toggle buttons). Would it be possible to restore it?

Kilvoctu commented 1 year ago

In the PR changes, it shows 4 lines of code that was removed from 2 files. You can open those files and paste the code back in at the indicated lines.

Aamir3d commented 1 year ago

In the PR changes, it shows 4 lines of code that was removed from 2 files. You can open those files and paste the code back in at the indicated lines.

To be frank, it is not a good solution. While I can do this, it will be with some difficulty as I'm not a developer. I'm sure others will be affected by this arbitrary removal of a functional button also.

Soulreaver90 commented 1 year ago

It wouldn’t be the first time a functional feature was removed either due to oversight or for no reason at all. I’m still using an old build because an option was removed and has yet to be restored. Lol

vladmandic commented 1 year ago

if button acts as toggle (which it does), which "functional feature" is missing? less clutter in ui, the better.

Aamir3d commented 1 year ago

if button acts as toggle (which it does), which "functional feature" is missing? less clutter in ui, the better.

I disagree @vladmandic - the close option was very visible, and even a regular user of A1111 like me didn't know this was a Toggle option. Maybe it's obvious to the developer, but not to me. And the UI wasn't really cluttered, there's still the refresh button next to it, and it would have made absolutely no difference with the additional close button. Once you Clicked close, all the Lora and Checkpoint tabs closed anyway.

Soulreaver90 commented 1 year ago

I mean if we are talking about clutter, the original intent of that PR was to change those buttons into small, yet visible emojis. However, that was refuted and resulted in a button being axed entirely. I personally liked the idea of turning the “refresh” and “close” into emojis. They have the same result, are easily identifiable and eases localization.

Nacurutu commented 1 year ago

There is no point to have more than 1 button with the same functionality...

The Extra networks button has a toggle behavior, we just need one.

as @vladmandic said:

less clutter in ui, the better.

Kilvoctu commented 1 year ago

In the PR changes, it shows 4 lines of code that was removed from 2 files. You can open those files and paste the code back in at the indicated lines.

To be frank, it is not a good solution. While I can do this, it will be with some difficulty as I'm not a developer. I'm sure others will be affected by this arbitrary removal of a functional button also.

I'm not a developer, either 👀. I learned Python explicitly for Stable Diffusion.
My own Web UI has several modifications that Github Desktop keeps for me through updates; certain things that's like, there's no way Auto will approve (such as putting preview on the left).

I apologize again for not providing proper UI feedback in my PR. I really don't like UI clutter, and a good UI can do more with less, in my opinion. I think this PR #8569 handles it well.
While I did like my initial emojis idea, Auto's refute and reasoning was agreeable, I think.

Aamir3d commented 1 year ago

In the PR changes, it shows 4 lines of code that was removed from 2 files. You can open those files and paste the code back in at the indicated lines.

To be frank, it is not a good solution. While I can do this, it will be with some difficulty as I'm not a developer. I'm sure others will be affected by this arbitrary removal of a functional button also.

I'm not a developer, either 👀. I learned Python explicitly for Stable Diffusion. My own Web UI has several modifications that Github Desktop keeps for me through updates; certain things that's like, there's no way Auto will approve (such as putting preview on the left).

I apologize again for not providing proper UI feedback in my PR. I really don't like UI clutter, and a good UI can do more with less, in my opinion. I think this PR #8569 handles it well. While I did like my initial emojis idea, Auto's refute and reasoning was agreeable, I think.

Please do not apologize! You are contributing, and working on this on your time. I appreciate all the effort that goes in by our hard working contributors and I mean it. I am in no way detracting from your effort and hard work. This is just a UI discussion. I agree that there should not be UI clutter and also saying at the same time 'don't fix what isn't broken' :-)

Really cool to hear that you're learning Python for SD. I wish you luck on your journey! PS: I don't think the preview on the left is a good idea either :-D - maybe I'm just too used to this interface now.

There is no point to have more than 1 button with the same functionality...

The Extra networks button has a toggle behavior, we just need one.

as @vladmandic said:

less clutter in ui, the better.

Thanks, but PLEASE make it obvious to a user of the interface? I am sure a lot of people had no idea it is a toggle.

Kilvoctu commented 1 year ago

It's the first time I contributed through a PR. Up until recently, I didn't want to touch the code much for various reasons, and instead sit in Discussions.
As for the saying, 'don't fix what isn't broken'. There are people who have trouble with that and look at anything and are like, 'can this be improved in some way?'
Anyway, I think the PR mentioned above is pretty good to intuitively help people in using 🎴

PS: I don't think the preview on the left is a good idea either :-D - maybe I'm just too used to this interface now.

I use Web UI often on my mobile device as well. Preview on left, on mobile, puts it right underneath 'styles'; otherwise, it's at the bottom of the screen and results in excessive scrolling needed.
Since mobile users are a minority I think, it's understandable that much of the Web UI isn't designed with it in mind.

Soulreaver90 commented 1 year ago

Today I learned that “button” is a toggle. I think the root issue, design wise, is that buttons and toggles are indistinguishable. Nobody should have to click things to find out how something works.

Aamir3d commented 1 year ago

There is no point to have more than 1 button with the same functionality...

The Extra networks button has a toggle behavior, we just need one.

as @vladmandic said:

less clutter in ui, the better.

Could you tell me how the presence (or not) of the close button adds to clutter in this UI? It is simpler to use, and I don't have to search (think user behavior from a user perspective) for a small target dot button to toggle it. image

There are other people who are affected with removing the close button as well, I'm not the only one. https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/8614

VRArt1 commented 1 year ago

I'd also prefer if the close button was returned. Maybe a setting for whether or not you have it?

victorca25 commented 1 year ago

I don't personally care about the close button, since I already know the functionality is in the toggle, but from the UX perspective, the toggle is not intuitive.

First time you open the UI, there's no way to know what that button does, out of all the buttons and tabs in the interface and there is no indication that it is in fact a toggle.

Sakura-Luna commented 1 year ago

Anyone can refer to the pr above to revert the Close button, but unless Auto changes its mind, it won't be reverted in the main repo.