search

AVATEAM-IT-SYSTEMHAUS / mkdocs-kroki-plugin

MkDocs plugin for Kroki-Diagrams
MIT License
46 stars 28 forks source link

Make image path relative #20

Closed ghost closed 1 year ago

ghost commented 1 year ago

Ensures legibility when opening as a file rather than a webpage. I need this to generate pdfs from the site files on github workflows.

ghost commented 1 year ago

Fixes #16.

b-bittner commented 1 year ago

@ITopiaJesseGoerzen

thanks for your contribution to the project, your help is really welcome. could you please resolve the merge-conflict, due to the newest changes in the code base. Thanks!

ghost commented 1 year ago

@b-bittner Resolved. Good to hear that this repo is being updated!

b-bittner commented 1 year ago

thanks, this looks good. If you don't mind, I would wait a few day for an answer from #16 @ssaraswati if this would also solve his problem.

ghost commented 1 year ago

It should fix his issue, but the reason I need it isn't really urgent either.

ghost commented 1 year ago

It's been a week. @ssaraswati is probably not going to pay attention to this pull request for some time, if ever. I'll be afk for 5 days and available on Tuesday 2023-01-17 if you need to get ahold of me again before merging.

ghost commented 1 year ago

I'm back from hiatus. Ask if you need fixes or questions answered.

ghost commented 1 year ago

This change would fix #25 .