search

AVATEAM-IT-SYSTEMHAUS / mkdocs-kroki-plugin

MkDocs plugin for Kroki-Diagrams
MIT License
46 stars 28 forks source link

`EmbedImages` configuration #31

Closed brianphillips closed 1 year ago

brianphillips commented 1 year ago

I see mention of the EmbedImages configuration option but I don't see it referenced anywhere else in the code. Is there a reason this plugin doesn't support embedding SVG files directly in the markdown code instead of just pulling the image in via an <img> tag?

My use case: Mermaid allows adding links to elements in a diagram but these don't work when referenced via an <img> tag

oniboni commented 1 year ago

Hi, I've checked the blame, and It was me :stuck_out_tongue_closed_eyes:

Sorry, my bad. For history: #9 and #8

I've just published my (companion) plugin to Pypi.

b-bittner commented 1 year ago

Thanks to @brianphillips and @oniboni I've merged the cleanup PR.