AVATEAM-IT-SYSTEMHAUS / mkdocs-kroki-plugin

MkDocs plugin for Kroki-Diagrams
MIT License
41 stars 27 forks source link

support whitespace after fenced block #34

Closed nolange closed 1 month ago

nolange commented 1 year ago

Hello,

I am using pandoc as reference (as "markdown formatter") and it is common that fenced blocks contain a whitespace, like this:

``` plantuml
@startuml
stop
@enduml
```

This unfortunately does not work, but the only issue seems to be the whitespace, this works:

```plantuml
@startuml
stop
@enduml
```

So please make the detection a bit less strict and allow whitespaces.

oniboni commented 1 month ago

You can achieve this via the config:

plugins:
  ...
  - kroki:
      - FencePrefix: ' '
nolange commented 1 month ago

Nah, its not completed, I cant adjust the config for every (part of a) file. Whitespaces should not matter at all, and dont for all other implemenations I know of. The code has more issues, most of which are addresses in #36 , which brings it more in line with the "de jure" spec of fenced-code-blocks.

oniboni commented 1 month ago

@nolange Oh sorry. Thanks for the links! I will see through them and add tests as well :grinning:

nolange commented 1 month ago

Thanks, this project felt abandoned for a while ;)

oniboni commented 1 month ago

@nolange

Thanks, this project felt abandoned for a while ;)

I know.. We all try our best to fit this in between our normal working hours :wink: