fix: image substitution - Githubissues

AVATEAM-IT-SYSTEMHAUS / mkdocs-kroki-plugin

MkDocs plugin for Kroki-Diagrams

MIT License

41 stars 27 forks source link

fix: image substitution #66

Closed oniboni closed 1 month ago

oniboni commented 1 month ago

[x] replace markdown with html in on_page_markdown, bc it does not get reevaluated inside of inline html
[x] try out the object tag
[ ] (optional) add selenium tests to compare the layout

Closes: #35, #61

jonesbusy commented 1 week ago

Thanks. It works great with mkdocs-material.

But apparently it break rendering on Backstage (https://github.com/backstage/backstage) in both preview and recommended deployment approach https://backstage.io/docs/features/techdocs/how-to-guides/#how-to-add-mermaid-support-in-techdocs

I will try to give more detail later today

colinodell commented 1 week ago

But apparently it break rendering on Backstage

Backstage explicitly forbids the use of <object> elements due to https://github.com/advisories/GHSA-gg96-f8wr-p89f. See also https://backstage.io/docs/features/techdocs/troubleshooting#plantuml-with-svg_object-doesnt-render

jonesbusy commented 1 week ago

The issue is https://github.com/AVATEAM-IT-SYSTEMHAUS/mkdocs-kroki-plugin/issues/70

Well...

@oniboni Can it be svg inline instead of object (https://github.com/AVATEAM-IT-SYSTEMHAUS/mkdocs-kroki-plugin/pull/66/files#diff-3f0b1dfd4eaf4f071c1adf4d665fff5854020c6dfcf87210551af489a1b298b7R29) ? We font should also load when <svg is rendered inline instead of via src

Thanks