search

AVAnnotate / admin-client

Application for building AVAnnotate websites
0 stars 0 forks source link

Mismatch between Project Tile and Project Settings lists of Project Members #27

Open absempere opened 1 month ago

absempere commented 1 month ago

The Project tile shows 4 GH users:

Screenshot 2024-08-02 at 11 38 02 AM

The Project Settings for this project only shows 1 GH user:

Screenshot 2024-08-02 at 11 38 20 AM

They should be showing the same list of 4 users.

camdendotlol commented 1 month ago

From Lorin:

So this can probably be refactored. the additional_users array are users that were specifically added via project creation/update. The users array is pulled from GitHub and includes users that were added to the repo outside of the UI. We should probably populate the additional_users array in settings with the users array which is more definitive. (edited)

Will look into this Monday morning.

SteveMarvin commented 3 weeks ago

Currently I cannot save new users to the project. I can add them, but once I save they disappear and are no longer on the list when I reenter Settings. And of course they are not showing on the card.

camdendotlol commented 2 days ago

@SteveMarvin I can't replicate the issue with adding new users to a project. I vaguely remember Lorin fixing something along those lines, so it's possible that he took care of this. Adding to review/QA for another pass.

SteveMarvin commented 2 days ago

@camdendotlol I'm afraid these are two separate bugs, and neither are fixed for me. This bug was opened regarding the user list under settings not showing the same lineup as the project card. That is still happening.

My comment was that I could not test this on a new project because users that I add are not saving once I click save. That is also still happening.

I'll put a new bug in for the adding new users problem, this bug should be for the user list mismatch.