Tickets addressed: bsk-735 "Hardcoded Isp in thrusterStateEffector"
Review: By commit
Merge strategy: Merge (no squash)
Description
A hard coded value is removed from the thrusterStateEffector that was erroneously forcing mass depletion always on. Then mass depletion logic is updated to check ThrustFactorto see if a thruster is firing rather than IspFactor which is unused by the thrusterStateEffector. Additionally, the mass depletion is changed to now scale its expenditure according to the scaled value of thrust following ramp up/down.
Verification
The FuelTank mass depletion unit test already produces plots of the fuel expenditure for a thruster dynamic and state effector, and the state effector's plots for mass and massDot vs. time now accurately reflect the firing pattern. While mass depletion was being plotted, no assertions were made as to accuracy of the values, so two assertions have been added to the fuel tank's mass depletion unit test checking that massDot is ramped up when the thruster is firing and ramped down when the thruster is commanded off.
Additionally, the thrusterStateEffector unit test is updated to scale the thrust by its ramp up/down factor when computing truth values for massDot comparison when toggled on for mass depletion force contributions.
Documentation
No documentation is invalidated by these changes, just fixing code to match what the documentation outlines. Release notes and known issues have been updated to identify this issue and resolution.
Description
A hard coded value is removed from the
thrusterStateEffectorthat was erroneously forcing mass depletion always on. Then mass depletion logic is updated to checkThrustFactorto see if a thruster is firing rather thanIspFactorwhich is unused by thethrusterStateEffector. Additionally, the mass depletion is changed to now scale its expenditure according to the scaled value of thrust following ramp up/down.Verification
The FuelTank mass depletion unit test already produces plots of the fuel expenditure for a thruster dynamic and state effector, and the state effector's plots for
massandmassDotvs. time now accurately reflect the firing pattern. While mass depletion was being plotted, no assertions were made as to accuracy of the values, so two assertions have been added to the fuel tank's mass depletion unit test checking that massDot is ramped up when the thruster is firing and ramped down when the thruster is commanded off.Additionally, the
thrusterStateEffectorunit test is updated to scale the thrust by its ramp up/down factor when computing truth values for massDot comparison when toggled on for mass depletion force contributions.Documentation
No documentation is invalidated by these changes, just fixing code to match what the documentation outlines. Release notes and known issues have been updated to identify this issue and resolution.