search

AVSLab / basilisk

Astrodynamics simulation framework
https://hanspeterschaub.info/basilisk
ISC License
147 stars 61 forks source link

Enhancement/enhanced polyhedral gravity model #825

Closed julsanmer closed 1 month ago

julsanmer commented 1 month ago

Description

Changed the math to evaluate polyhedron gravity to be more computationally efficient. The key is to initialize and store several variables that are non-related to the evaluation point.

Verification

The polyhedron gravBody unit test succeeds.

Documentation

I've included html documentation for the polyhedron gravity. I think that by proceeding this way, the documentation is more clearer and accessible than with the big pdf on gravityEffector. But open to other thoughts.

Future work

Should the gravity models be stored in specific folders within the gravityEffector folder? It'd feel more organized this way. As my time allows, I'd try to PR other features that could be of interest to BSK project.

schaubh commented 1 month ago

I see odd structure in your branch now. Please use rebasing to make a clean branch, not merging. Also, let me know when ready to review again. Please do a rebase on develop before asking for next review to ensure there are no conflicts.