Fix RPATH when installing from source for macOS

AVSLab / basilisk

Astrodynamics simulation framework

https://hanspeterschaub.info/basilisk

ISC License

147 stars 61 forks source link

Fix RPATH when installing from source for macOS #832

Closed sassy-asjp closed 1 month ago

sassy-asjp commented 1 month ago

Tickets addressed: #826
Review: By commit
Merge strategy: Merge (no squash)

Description

The fix described in #826 which guesses the correct RPATH (similar to how it works on Linux) was implemented.

Verification

Tested:

Installing from git repo link
Installing from source tarball
Installing from a sdist hosted on our internal package repository

Documentation

None

Future work

None

sassy-asjp commented 1 month ago

I don't think there is any mechanism where the change could have possibly affected Linux opNav, so I think the CI failure was caused by some flaky test timing out.

schaubh commented 1 month ago

@sassy-asjp , I agree that this looks like a time-out issue. For the life of me I can't figure out why some test runs stall at different places and then time out occasionally. This started happening when I added additional tests to be run. It isn't the same run that times out, and not always at the same place. For now I simply re-run the tests that time out. Not ideal, I agree.

schaubh commented 1 month ago

I was able to test this on my macOS laptop and it worked. I added updated documentation and release notes.