AVSLab / basilisk

Astrodynamics simulation framework
https://hanspeterschaub.info/basilisk
ISC License
147 stars 61 forks source link

Refactor facetSRPDynamicEffector module #856

Open leahkiner opened 3 days ago

leahkiner commented 3 days ago

Describe your use case

The facetSRPDynamicEffector module currently has a bug when mapping the facet normal vectors to the spacecraft body frame. The computed DCM from the facet frame to the body frame must be transposed to obtain the correct transformation. Additionally, the module documentation and code should be cleaned up and reference frames need to be clarified in the PR.

Describe alternatives solutions you've considered N/A

Additional context N/A