AVSLab / bsk_rl

RL environments and tools for spacecraft autonomy research, built on Basilisk. Developed by the AVS Lab.
https://avslab.github.io/bsk_rl/
MIT License
39 stars 4 forks source link

scenario not defined on init #148

Closed nmharmon8 closed 3 months ago

nmharmon8 commented 3 months ago

ScanningTimeReward and scenario init order

When using the rllib training example, the scenario is not added to the ScanningTimeReward until GeneralSatelliteTasking calls link. Also added the ppo train call to the example notebook. The reward is also a dict not a float to take the average, which seem like what was intended, but dose not matter with one satellite.

Closes #147

Type of change

How should this pull request be reviewed?

How Has This Been Tested?

Just running the example, with

Please describe the tests that you ran to verify your changes.

Passes Tests

Have not got the unit tests working in my env