search

AVSystem / Anjay-mbedos-client

Apache License 2.0
3 stars 6 forks source link

mbed_app.json - do not default * to cellular #12

Closed JanneKiiskila closed 2 years ago

JanneKiiskila commented 2 years ago

Cellular should be really a target specific thing and/or overrride. The default mbed_app.json should really allow the default machine config to give what it has, you then override per target.

F429ZI for example can't be compiled with this mbed_app.json (without modifying it). Nor any other target w/o cellular either (read: bulk of all targets). Targets that have a network interface out-of-box in Mbed OS have also the default network interface defined, as is.

JanneKiiskila commented 2 years ago

@kFYatek - please review.

kFYatek commented 2 years ago

~Thanks, merged!~ Oh, you closed it before I could merge it. So anyway, I'm pretty sure there will be a release today.

JanneKiiskila commented 2 years ago

Looking forward to that released @kFYatek .