Date truncation fix - Githubissues

bgrochal commented 5 years ago

Changes:

Calendar.DAY_OF_YEAR argument (causing IllegalArgumentException) switched to Calendar.DAY_OF_MONTH in EnrichedDate#truncateToDays implementation,
Tests for truncation methods in EnrichedDate implemented.

ghik commented 5 years ago

Can you give a quick example of what was wrong with the previous implementation?

bgrochal commented 5 years ago

Sure, previous implementation (DateUtils.truncate(wrapped, Calendar.DAY_OF_YEAR)) throws:

The field 6 is not supported
java.lang.IllegalArgumentException: The field 6 is not supported
    at org.apache.commons.lang3.time.DateUtils.modify(DateUtils.java:1103)
    at org.apache.commons.lang3.time.DateUtils.truncate(DateUtils.java:819)
        ....

The simplest way to reproduce is to change Calendar.DAY_OF_MONTH field back to Calendar.DAY_OF_YEAR and run my tests. Please refer also to the DateUtilImpl#truncateByDay implementation (correct) and this solution.

ghik commented 5 years ago

Oh, so it just never worked :laughing: that's pretty clear.

AVSystem / scex

Date truncation fix #3