search

AViewFromTheTop / SimpleCopperPipesMC

Source code for the Simple Copper Pipes Minecraft mod.
MIT License
7 stars 7 forks source link

[BUG] The copper pipe is reversely connected to the shulker box to place items into the Shulker box. #16

Closed QianFuv closed 1 year ago

QianFuv commented 1 year ago

https://github.com/Qian-F/QFserver-Wonder/assets/99337738/f9919126-61f1-4916-bfcb-3a39385001c9

QianFuv commented 1 year ago

@AViewFromTheTop check this issue plz

AViewFromTheTop commented 1 year ago

I don’t see an issue with this. The side of the pipe with the “lip” on it is the side that the pipe pushes items towards.

QianFuv commented 1 year ago

I don’t see an issue with this. The side of the pipe with the “lip” on it is the side that the pipe pushes items towards.

But this leads to shulker boxes being able to nest Shulker boxes. I don't think that's allowed.

AViewFromTheTop commented 1 year ago

I don’t see an issue with this. The side of the pipe with the “lip” on it is the side that the pipe pushes items towards.

But this leads to shulker boxes being able to nest Shulker boxes. I don't think that's allowed.

OH. Ok, thats the issue, I somehow hadn’t realized. I’ll reopen this issue, thank you!

QianFuv commented 1 year ago

I don’t see an issue with this. The side of the pipe with the “lip” on it is the side that the pipe pushes items towards.

But this leads to shulker boxes being able to nest Shulker boxes. I don't think that's allowed.

OH. Ok, thats the issue, I somehow hadn’t realized. I’ll reopen this issue, thank you!

Hopefully you can fix this soon, maybe by adding a judgment between the copper tube and shulker box, can you release a fix for 1.18.2?

QianFuv commented 1 year ago

I don’t see an issue with this. The side of the pipe with the “lip” on it is the side that the pipe pushes items towards.

But this leads to shulker boxes being able to nest Shulker boxes. I don't think that's allowed.

OH. Ok, thats the issue, I somehow hadn’t realized. I’ll reopen this issue, thank you!

@AViewFromTheTop

I'm sorry to bother you again. Can you give me an approximate time to fix this bug? Since it depends on whether I should add it to my server, this vulnerability can cause a lot of problems.

AViewFromTheTop commented 1 year ago

I've just fixed it for 1.20, I will release fixes for older versions soon.

QianFuv commented 1 year ago

I've just fixed it for 1.20, I will release fixes for older versions soon.

Thank you for your efforts! Thank you so much!!