AWSW-de / WordClock-16x8-LED-matrix

WordClock 16x16 LED matrix (2023)
GNU General Public License v3.0
22 stars 8 forks source link

Remove the second row led calls and automatically find the sibling led by calculation #8

Closed jandegraaf closed 8 months ago

jandegraaf commented 8 months ago

I was tired of looking up the correspondent second row leds and constantly mistyping the numbers, so I thought there would be a nicer way to do this trick.

My PR adds a method that calculates the second row led (aka sibling). I extended the setLED() and setLEDcol() methods to retrieve this information and subsequently removed all second row calls to these methods.

Hope it helps!

AWSW-de commented 8 months ago

Merged successfully. Thanks for this great solution which i wanted to add all the time and never got to it... That was really helpful, thanks a lot! =)

I found some "2nd row" entries during revier in your LTZ language like around line 3395 and 3465 which should not affect the function but might be redundant... Can you please confirm, then i would search and remove them. Thanks in advance. =)