AWhiteKnight / ioBroker.letrika_comgw

Adapter for Letrika Communication Gateway (aka SolGate, SunGate)
MIT License
0 stars 2 forks source link

Letrika: implement comments #4

Closed AWhiteKnight closed 5 years ago

AWhiteKnight commented 5 years ago

[x] you should remoe .vscode from GitHub [x] you can use https://translator.iobroker.in/ to translate news texts and words.js for all languages [x] if you do not need "on-State-Changed" or "on-Objects-changed" then do not use it. better performance [x] you use intervalls, this brings a risk because you also do massive "external communications". If the communication is running into timeouts or such then the next intervall will hard fire the next requests and so on ... Please make sure that this is not "DOSing" the device or make problems in the adapter. Ideally user setTimeout and set a new timeout after the logic was executed [x] you are creating many object sat the beginning. Plese have in mind that all of this is executed asyncronous. This can cause errors like "stack size exceeded". It would be better to collect all the objects to be created in an array and then process these using callbacks or promises one afte rthe other...