AXeL-dev / distract-me-not

:no_entry: A lightweight website blocker with a user friendly interface
https://addons.mozilla.org/addon/distract-me-not/
MIT License
122 stars 14 forks source link

FF 91.9.0esr - The extension can be disabled even when the password is set #60

Closed mabequinho closed 2 years ago

mabequinho commented 2 years ago

Version 2.6.5

FF 91.9.0esr (64-bit) from Debian stable repos

AXeL-dev commented 2 years ago

Hum :thinking: , Can you provide more details please? Like the websites you're trying to block? (you can send that to me on my email if it's confidential).

Also a screenshot of the issue or a video might help me to better understand. Thank you.

Edit: does version 2.6.4 work well?

mabequinho commented 2 years ago

same issue using 2.6.4, i´m using whitelist mode.

You may need to download the video to watch it properly.

https://user-images.githubusercontent.com/46428150/167856411-e4e2842c-11a1-4db6-bbae-342de69d8de9.mp4

AXeL-dev commented 2 years ago

same issue using 2.6.4, i´m using whitelist mode.

You may need to download the video to watch it properly. distractmetest.mp4

Do you have the domain name youtube.com on your whitelist? can you send me a screenshot of the whitelist settings please. I might need to know what's on your blacklist settings as well. Thank you.

mabequinho commented 2 years ago

same issue using 2.6.4, i´m using whitelist mode. You may need to download the video to watch it properly. distractmetest.mp4

Do you have the domain name youtube.com on your whitelist? can you send me a screenshot of the whitelist settings please. I might need to know what's on your blacklist settings as well. Thank you.

My friend, the blocking procedures are working flawlessly, the problem is that i can disable the entire extension without password by directly entering the add-ons and configuration FF menus. photo_2022-05-11_11-40-11

AXeL-dev commented 2 years ago

My friend, the blocking procedures are working flawlessly, the problem is that i can disable the entire extension without password by directly entering the add-ons and configuration FF menus. photo_2022-05-11_11-40-11

This is a known issue, & firefox doesn't provide a way to disallow the user from disabling an extension, you should open an issue in the mozilla addons repo for that.

Additionnaly, even your password can be bypassed easily (check this https://github.com/AXeL-dev/distract-me-not/issues/27#issuecomment-854942738).

mabequinho commented 2 years ago

this addon foxfilter can do it.

AXeL-dev commented 2 years ago

this addon foxfilter can do it.

They probably use a hacky way for that, since from what i know there is no API that let you do this.

Nonetheless, i'll try to have a look on their code source if it's open source & check how it is implemented.

mabequinho commented 2 years ago

I am currently using the following policies.json file as a workaround. It prevents disable and/or uninstall.

{ "policies": { "ExtensionSettings": { "uBlock0@raymondhill.net": { "installation_mode": "force_installed", "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi" }, "{5f884915-160e-4276-a216-770a753a3abe}": { "installation_mode": "force_installed", "install_url": "https://addons.mozilla.org/firefox/downloads/latest/distract-me-not/latest.xpi" }, "Extensions": { "Locked": ["{5f884915-160e-4276-a216-770a753a3abe}"] } } } }

AXeL-dev commented 2 years ago

I am currently using the following policies.json file as a workaround. It prevents disable and/or uninstall.

{ "policies": { "ExtensionSettings": { "uBlock0@raymondhill.net": { "installation_mode": "force_installed", "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi" }, "{5f884915-160e-4276-a216-770a753a3abe}": { "installation_mode": "force_installed", "install_url": "https://addons.mozilla.org/firefox/downloads/latest/distract-me-not/latest.xpi" }, "Extensions": { "Locked": ["{5f884915-160e-4276-a216-770a753a3abe}"] }, } } }

:thinking: this looks interesting, still i'm not sure if there is an API on firefox that let you update/add new policies, otherwise i think that the solution used by foxfilter isn't so hard to implement, so i'll be working on it once i have some time to.

AXeL-dev commented 2 years ago

Fixed in version 2.7.0, you still need to enable the following option in the settings:

Capture d'écran Deepin_zone de sélection _20220514193447