search

AY1920S1-CS2103-T16-1 / main

SugarMummy
https://ay1920s1-cs2103-t16-1.github.io/main/
MIT License
0 stars 5 forks source link

Deleting 3rd consecutive record does not set achievement to Previously achieved #133

Closed nus-pe-bot closed 4 years ago

nus-pe-bot commented 4 years ago

image.png

image.png

image.png

image.png

image.png

[original: Xelyion/ped#3]

whneo97 commented 4 years ago

[For reference; commented on original issue]

Hi, thanks for the input! This behaviour is currently intended, as described in the user guide https://github.com/AY1920S1-CS2103-T16-1/main/blob/master/docs/UserGuide.adoc#show-a-list-of-all-achievements-the-user-has-attained-achvm

Achievements are currently awarded based on data available to the program (evidence based on the record list rather than a separate tracker to track whether or not the achievement has literally been attained "before"). This is as the user is likely to have deleted the record because it was erroneous, and as such may not truly have received the bronze award.

A scenario where the user could receive YET TO ACHIEVE could be when he / she received the bronze award for 3 days, and thereafter on the next day, failed to meet the requirement. As such the user would have clearly received the award before based on records but no longer holds it due to the lost streak.

Please feel free to let us know in further comments if there happens to be any suggestions to improve this, whether the idea / explanation is reasonable and if there are better alternatives to this idea and reasoning. Otherwise, will proceed to close this issue?

Thanks!