AY1920S1-CS2103T-W11-2 / main

SplitWiser - Epic debt tracking
https://ay1920s1-cs2103t-w11-2.github.io/main/
MIT License
0 stars 5 forks source link

Add activity diagram for expense #202

Closed liakify closed 4 years ago

liakify commented 4 years ago

Activity diagram looks good! @liakify give us a heads up when you want it merged.

Aside: actually, for the section where the Expense commands loops through the participants supplied, that can actually be represented as a branching statement that loops back to a diamond until it runs out of participant names. I think that's the convention for loops, so you might want to consider that in place of 'For each person, search for contacts in the search scope using the search terms'.

I tried doing that but activity diagram loops are structured more like while loops and it was kinda hard to specify the looping condition in a way that still made sense for reading & doc purposes (or maybe its just my english).

But yes pls merge

Aulud commented 4 years ago

Activity diagram looks good! @liakify give us a heads up when you want it merged. Aside: actually, for the section where the Expense commands loops through the participants supplied, that can actually be represented as a branching statement that loops back to a diamond until it runs out of participant names. I think that's the convention for loops, so you might want to consider that in place of 'For each person, search for contacts in the search scope using the search terms'.

I tried doing that but activity diagram loops are structured more like while loops and it was kinda hard to specify the looping condition in a way that still made sense for reading & doc purposes (or maybe its just my english).

But yes pls merge

Noted haha; merged as requested.