Feedback on week 6 project progress for CS2113T-W13-1

[nus-pe-script]

Leftovers from the previous week

• [x] A version tagged v1.0 is in the repo(:heavy_check_mark: well done!)

• [x] You are done with previous weeks work(:heavy_check_mark: well done!)

Progress of this week

• [x] A version tagged A-Gradle is in the repo(:heavy_check_mark: well done!)

• [x] A version tagged A-CheckStyle is in the repo(:heavy_check_mark: well done!)

• [x] A version tagged A-Jar-BugFix is in the repo(:heavy_check_mark: well done!)( :warning: The tag is slightly different from the expected value (A-Jar). Please follow the exact tag in future )

• [x] A version tagged B-Reminders is in the repo(:heavy_check_mark: well done!)

• [ ] A version tagged B-FindFreeTimes is in the repo(:exclamation: try to do by next milestone)

• [x] A version tagged B-ViewSchedules is in the repo(:heavy_check_mark: well done!)

• [ ] A version tagged B-DetectAnomalies is in the repo(:exclamation: try to do by next milestone)

• [ ] A version tagged B-Snooze is in the repo(:exclamation: try to do by next milestone)

• [ ] A version tagged B-TentativeScheduling is in the repo(:exclamation: try to do by next milestone)

• [ ] A version tagged B-RecurringTasks is in the repo(:exclamation: try to do by next milestone)

• [x] A version tagged B-DoAfterTasks is in the repo(:heavy_check_mark: well done!)

• [ ] A version tagged B-DoWithinPeriodTasks is in the repo(:exclamation: try to do by next milestone)

• [ ] A version tagged B-FixedDurationTasks is in the repo(:exclamation: try to do by next milestone)

• [ ] Updated the README page(:exclamation: try to do by next milestone)

• [ ] Made a release containing a JAR file.(:exclamation: try to do by next milestone)

  Individual progress of @danisheddie

• [x] Team repo forked to your GitHub account(:heavy_check_mark: well done!)

• [ ] You have reviewed at least 1 PR(:exclamation: try to do by next milestone)

PR created for:

• [x] [CS2113T-W13-1]-danisheddie-B-FixedDurationTasks

• [x] [CS2113T-W13-1]-danisheddie-A-Jar

  Individual progress of @nottherealedmund

• [x] Team repo forked to your GitHub account(:heavy_check_mark: well done!)

• [ ] You have reviewed at least 1 PR(:exclamation: try to do by next milestone)

PR created for:

• [x] [CS2113T-W13-1]-NotTheRealEdmund-B-DoAfterTasks

  Individual progress of @eujingsen

• [x] Team repo forked to your GitHub account(:heavy_check_mark: well done!)

• [ ] You have reviewed at least 1 PR(:exclamation: try to do by next milestone)

PR created for:

• [x] [CS2113T-W13-1]-eujingsen-B-ViewSchedules

• [x] [CS2113T-W13-1]-eujingsen-B-ViewSchedules

  Individual progress of @sfloydzy

• [x] Team repo forked to your GitHub account(:heavy_check_mark: well done!)

• [x] You have reviewed at least 1 PR(:heavy_check_mark: well done!)

PR created for:

• [x] [CS2113T-W13-1]-Sfloydzy-B-Reminders

Tutor: @flxffy

_{Note: the above observation was done by the CS2113-feedback-bot and covers changes up to 2019-09-18 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.}

[Sfloydzy]

Hi the README file was updated and there was a release with the JAR file

[flxffy]

@Sfloydzy The mid-v1.1 release didn't have a JAR file! You can see this under the release's assets

For your convenience: https://github.com/AY1920S1-CS2113T-W13-1/main/releases/tag/mid-v1.1

[Sfloydzy]

The JAR file was included in the mid-v1.1-BugFix tag!

https://github.com/AY1920S1-CS2113T-W13-1/main/commit/1cdb722c20a978d24e90db53315386cb8d79b775

[flxffy]

The JAR file has a .jar extension, which is also missing in that release.

This is how it should look like:

[Sfloydzy]

@flxffy So to clarify, in the future the jar file needs to be attached to the tag instead of simply being committed to the repo directories?

In the mid-v1.1-BugFix tag I included it inside the build folder.

[flxffy]

The JAR file should be uploaded when the release is created. You can refer to step 7 here