search

AY1920S2-CS2103T-F10-2 / main

Github page for My Internship Diary
https://ay1920s2-cs2103t-f10-2.github.io/main/
MIT License
0 stars 5 forks source link

Display of GHOSTED status #134

Closed FeliciaTay closed 4 years ago

foochifa commented 4 years ago

Sorry just to confirm. So lastStage will usually be == status (current) unless the IA has been edited to Rejected/Ghosted right?

Because if this is the case, then the primary IA constructor should follow, instead of setting lastStage to null, it will be better to follow the default and set it to status. Not really good to carry null final values.

And the printing of last stage is handled by the getLastStageMessage in IA?

FeliciaTay commented 4 years ago

@foochifa Last Status will usually be null unless the IA edited to Rejected/Ghosted. Yep, the printing of last stage is handled by getLastStageMessage

foochifa commented 4 years ago

Yup okay thanks! Im still not sure about having null final values though, but we can change it next time.

Goodjob!