AY1920S2-CS2103T-F10-2 / main

Github page for My Internship Diary
https://ay1920s2-cs2103t-f10-2.github.io/main/
MIT License
0 stars 5 forks source link

[PE-D] Email format constraints incorrect #188

Closed nus-pe-bot closed 4 years ago

nus-pe-bot commented 4 years ago

It is specified that the constraint for email formats are:

Emails should be of the format local-part@domain and adhere to the following constraints:

  1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (!#$%&'*+/=?`{|}~^.-) .
  2. This is followed by a '@' and then a domain name. The domain name must:
    • be at least 2 characters long
    • start and end with alphanumeric characters
    • consist of alphanumeric characters, a period or a hyphen for the characters in between, if any.

This allows for cases such as:

Not a very realistic constraint for email formats.

Screenshot 2020-04-03 at 2.30.11 PM.png


Labels: severity.Medium type.FunctionalityBug original: firzanarmani/ped#1

gerhean commented 4 years ago

https://en.wikipedia.org/wiki/Email_address#Internationalization Local part having 1 symbol is actually a valid email. Hyphen in sequence is a valid email. Dot less domain is valid (but not recommended).

In order to avoid having overly complex regex, we will refrain from checking every single possible allowed combination.

Will update UG.