Open nishantbudhdev opened 4 years ago
Regarding the number 10 points, the sd is for the reference at the import command sequence diagram at the top of the diagram.
Furthermore, how could I show the exception path if it is being thrown in the sequence uml diagram?
@nishantbudhdev Hi nishan regarding point 9, is a static class embedded in a class not a composition? Because EditParcelDescriptor is a sub static class in EditCommand class.
Here are some comments and questions that may help you improve your DG.
Is your architecture the same as AddressBook? If not, please update the architecture diagram.
Suggestion: ReturnOrder and Order have a lot of common attributes. Can you think of a way to make a better OOP solution?
Suggestion: Remove unconnected components. Or break this diagram to multiple UML diagrams and explain each of them individually.
Sec 2.6 -> Classes used by multiple components are in the
seedu.addressbook.commons
package. Do you still use theaddressbook
as the package name? Otherwise good job in updating the content to remove references to AddressBook application.Too many details in the diagram. Remove getter/setter functions, trivial data members. Also, split the diagram into multiple UML diagrams since there are two disjoint sets of classes. Use similar methods for simplifying other class diagrams.
Suggestion: Reduce verbosity and details. For example, "Creates new InsertCommand object and calls execute method." (Figure 10) Use similar techniques for other boxes in the activity diagram throughout the DG.
Suggestion: Remove implicit arguments. Therefore you can omit arguments for both
parseCommand()
andparse()
. (Figure 11)Are you missing an conditional box for true and false here? (Figure 17)
Is this the correct composition direction arrow?
What is
sd Execution of the Import Command Sequence Diagram
?Great job on Appendix G.
Overall try and reduce the complexity and details in your UML diagrams. Everything else looks good. 👍