AY1920S2-CS2103T-W17-2 / main

Notably
https://ay1920s2-cs2103t-w17-2.github.io/main/
MIT License
3 stars 4 forks source link

Update currentlyOpenBlock on block delete #407

Closed firzanarmani closed 4 years ago

firzanarmani commented 4 years ago

Closes #354

Fixes currentlyOpenBlock not updating when the currentlyOpenBlock is delete by using a RelativePath with delete .

currentlyOpenBlock will now change to its the deleted block's parent upon successful deletion.

EDIT: ~- Deleting some distant block from currentlyOpenBlock will still open to that distant block's parent~

netlify[bot] commented 4 years ago

Deploy preview for notably-app ready!

Built with commit 46a5fa54124b8dd57d57565331ba8f0d47a6883d

https://deploy-preview-407--notably-app.netlify.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #407 into master will increase coverage by 0.05%. The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #407      +/-   ##
============================================
+ Coverage     65.87%   65.92%   +0.05%     
- Complexity      547      550       +3     
============================================
  Files            99       99              
  Lines          2157     2169      +12     
  Branches        209      211       +2     
============================================
+ Hits           1421     1430       +9     
- Misses          657      659       +2     
- Partials         79       80       +1     
Impacted Files Coverage Δ Complexity Δ
...ava/com/notably/model/block/BlockTreeItemImpl.java 89.15% <66.66%> (-2.74%) 30.00 <3.00> (+2.00) :arrow_down:
...n/java/com/notably/model/block/BlockModelImpl.java 77.41% <100.00%> (+2.41%) 10.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca2eedd...46a5fa5. Read the comment docs.

kevinputera commented 4 years ago

@firzanarmani Hey Firzan, this doesn't seem to be working. I screen recorded the problem I encountered below.

Kapture 2020-04-08 at 10 26 41

You can try out the sequence above. In my place, the whole app crashes as that command was executed.

firzanarmani commented 4 years ago

You can try out the sequence above. In my place, the whole app crashes as that command was executed.

Missed out something, thanks for picking it out @kevinputera

  • Deleting some distant block from currentlyOpenBlock will still open to that distant block's parent

What do you think about this?