AY1920S2-CS2103T-W17-2 / main

Notably
https://ay1920s2-cs2103t-w17-2.github.io/main/
MIT License
3 stars 4 forks source link

Update valid path criteria #419

Closed kevinputera closed 4 years ago

kevinputera commented 4 years ago

Closes #415

Sorry for the messy PR. It works on a few things, mainly:

  1. Update ...Path's VALIDATION_REGEX to follow that of Title.
  2. Refactor NewCommand and NewCommandParser by a bit.
  3. Remove TO_ROOT_PATH constant. I believe this was created in the past due to InvalidPathException being a checked exception, which made calling AbsolutePath#fromString very troublesome. Since InvalidPathException is no longer a checked exception, let's remove the constant.
  4. Update ...PathTest's test cases
netlify[bot] commented 4 years ago

Deploy preview for notably-app ready!

Built with commit 99b30577eefa5649aa1c89b4c152d04761230fe0

https://deploy-preview-419--notably-app.netlify.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #419 into master will decrease coverage by 0.03%. The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #419      +/-   ##
============================================
- Coverage     67.14%   67.11%   -0.04%     
+ Complexity      519      518       -1     
============================================
  Files            98       98              
  Lines          2027     2025       -2     
  Branches        201      201              
============================================
- Hits           1361     1359       -2     
  Misses          580      580              
  Partials         86       86              
Impacted Files Coverage Δ Complexity Δ
...in/java/com/notably/commons/path/AbsolutePath.java 90.47% <ø> (-0.23%) 17.00 <0.00> (-1.00)
...in/java/com/notably/commons/path/RelativePath.java 65.95% <ø> (ø) 14.00 <0.00> (ø)
...in/java/com/notably/model/util/SampleDataUtil.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/com/notably/logic/commands/NewCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...ava/com/notably/logic/parser/NewCommandParser.java 69.56% <100.00%> (ø) 3.00 <0.00> (ø)
...n/java/com/notably/model/block/BlockModelImpl.java 75.00% <100.00%> (ø) 9.00 <0.00> (ø)
...om/notably/storage/JsonSerializableBlockModel.java 95.12% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9de3387...99b3057. Read the comment docs.