search

AY2021S1-CS2103T-T09-1 / tp

MIT License
0 stars 4 forks source link

Required command addons #133

Closed yan-soon closed 4 years ago

yan-soon commented 4 years ago

RequiredCommand

Added 2 new methods to compare GEMs.

GemCommand

Added new GemCommand class to showcase all the possible GE modules available in Sem 1 and Sem 2. Design is the same as RequiredCommand class.

GemCommandStorage

Added new GemCommandStorage class to deal with GE module storage. Design is the same as RequiredCommandStorage class.

GemCommandTest and GemCommandStorageTest

Added new test classes, coverage is at 95% and 100% respectively.

MathAndScience Changed all MathAndScience messages, methods and attributes to just Math (rectify typo)

isValid() methods for Title and Credits Removed the above methods, since we no longer require them. Removed all the relevant testing for them as well.

codecov-io commented 4 years ago

Codecov Report

Merging #133 into master will increase coverage by 1.24%. The diff coverage is 96.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
+ Coverage     75.37%   76.62%   +1.24%     
- Complexity      534      562      +28     
============================================
  Files            89       92       +3     
  Lines          1600     1694      +94     
  Branches        165      171       +6     
============================================
+ Hits           1206     1298      +92     
- Misses          316      319       +3     
+ Partials         78       77       -1
Impacted Files Coverage Δ Complexity Δ
...a/seedu/address/logic/commands/ScienceCommand.java 87.50% <ø> (ø) 5.00 <0.00> (ø)
...java/seedu/address/logic/parser/GradPadParser.java 75.00% <0.00%> (-3.27%) 14.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.29% <ø> (+5.97%) 10.00 <0.00> (-1.00) :arrow_up:
...ava/seedu/address/model/module/ModularCredits.java 75.00% <ø> (-5.00%) 5.00 <0.00> (-1.00)
...n/java/seedu/address/model/module/ModuleTitle.java 62.50% <ø> (-7.50%) 4.00 <0.00> (-1.00)
...java/seedu/address/storage/GemCommandMessages.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/seedu/address/storage/JsonAdaptedModule.java 100.00% <ø> (ø) 7.00 <0.00> (-2.00)
...seedu/address/storage/RequiredCommandMessages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/logic/commands/GemCommand.java 95.12% <95.12%> (ø) 8.00 <8.00> (?)
.../seedu/address/logic/commands/RequiredCommand.java 98.01% <100.00%> (+0.79%) 32.00 <10.00> (+10.00)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fbbaa39...5bfb642. Read the comment docs.