Closed yan-soon closed 4 years ago
Merging #176 into master will increase coverage by
0.12%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #176 +/- ##
============================================
+ Coverage 75.53% 75.66% +0.12%
- Complexity 565 573 +8
============================================
Files 93 93
Lines 1713 1738 +25
Branches 174 178 +4
============================================
+ Hits 1294 1315 +21
- Misses 338 341 +3
- Partials 81 82 +1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...seedu/address/storage/RequiredCommandMessages.java | 0.00% <ø> (ø) |
0.00 <0.00> (ø) |
|
...main/java/seedu/address/commons/util/JsonUtil.java | 94.87% <100.00%> (+0.42%) |
10.00 <1.00> (+1.00) |
|
.../seedu/address/logic/commands/RequiredCommand.java | 98.21% <100.00%> (+0.19%) |
37.00 <4.00> (+5.00) |
|
.../seedu/address/storage/RequiredCommandStorage.java | 100.00% <100.00%> (ø) |
16.00 <2.00> (+2.00) |
|
...java/seedu/address/logic/parser/GradPadParser.java | 75.00% <0.00%> (ø) |
14.00% <0.00%> (ø%) |
|
...rc/main/java/seedu/address/logic/LogicManager.java | 39.21% <0.00%> (+0.57%) |
5.00% <0.00%> (ø%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 89c6c8b...61719c7. Read the comment docs.
Updates:
Updated code as per team review.
Notable changes:
Updated required command to factor in equivalent and preclusion modules.
Notable changes:
JsonUtil
RequiredCommandStorage
RequiredCommand
Added the relevant tests for the new methods used.