AY2021S1-CS2103T-T09-1 / tp

MIT License
0 stars 4 forks source link

Add fdelete fclear command #178

Closed mhdsyfq77 closed 4 years ago

mhdsyfq77 commented 4 years ago

Resolves #157

Added:

mhdsyfq77 commented 4 years ago

Looks guuud; just tiny nits abt the javadocs!

And on a side note, should we write tests for ForceDeleteCommandParser? Since it's mostly a duplicate of DeleteCommandParser, perhaps we don't need to, so just asking!

yes we definitely do i totally forgot about that LOL cause if not coverage 0% xDDD

codecov-io commented 4 years ago

Codecov Report

Merging #178 into master will increase coverage by 0.08%. The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
+ Coverage     75.40%   75.48%   +0.08%     
- Complexity      572      579       +7     
============================================
  Files            93       96       +3     
  Lines          1736     1750      +14     
  Branches        178      179       +1     
============================================
+ Hits           1309     1321      +12     
- Misses          343      345       +2     
  Partials         84       84              
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
...java/seedu/address/logic/parser/GradPadParser.java 69.23% <0.00%> (-5.77%) 14.00 <0.00> (ø)
...eedu/address/logic/commands/ForceClearCommand.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...edu/address/logic/commands/ForceDeleteCommand.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...address/logic/parser/ForceDeleteCommandParser.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb84a77...2b3ed5c. Read the comment docs.