search

AY2021S1-CS2103T-T09-1 / tp

MIT License
0 stars 4 forks source link

Add tests for parsers #208

Closed Silvernitro closed 4 years ago

Silvernitro commented 4 years ago

Add negative tests for AddCommandParser and EditCommandParser when a module search fails. Tweaked both classes slightly to allow stubbing of ModuleInfoSearcher

Logic package has 100% line coverage now WOOO

Closes #207

codecov-io commented 4 years ago

Codecov Report

Merging #208 (138ed40) into master (93bb370) will increase coverage by 0.31%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #208      +/-   ##
============================================
+ Coverage     81.36%   81.68%   +0.31%     
- Complexity      647      650       +3     
============================================
  Files            96       96              
  Lines          1771     1780       +9     
  Branches        185      185              
============================================
+ Hits           1441     1454      +13     
+ Misses          259      255       -4     
  Partials         71       71
Impacted Files Coverage Δ Complexity Δ
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (+11.11%) 5.00 <2.00> (+1.00)
.../seedu/address/logic/parser/EditCommandParser.java 94.11% <100.00%> (+7.91%) 12.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93bb370...138ed40. Read the comment docs.