search

AY2021S1-CS2103T-T10-3 / tp

https://ay2021s1-cs2103t-t10-3.github.io/tp/
MIT License
0 stars 4 forks source link

More issue closing #287

Closed seowalex closed 4 years ago

seowalex commented 4 years ago

Fixes #147. Slightly modifies behaviour to throw an error when trying to add tags that already exist (previously, they would show a successful editing of the recipe/ingredient).

codecov-io commented 4 years ago

Codecov Report

Merging #287 into master will decrease coverage by 0.18%. The diff coverage is 83.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #287      +/-   ##
============================================
- Coverage     84.52%   84.33%   -0.19%     
- Complexity     1607     1625      +18     
============================================
  Files           139      141       +2     
  Lines          4128     4207      +79     
  Branches        528      541      +13     
============================================
+ Hits           3489     3548      +59     
- Misses          529      543      +14     
- Partials        110      116       +6
Impacted Files Coverage Δ Complexity Δ
...ava/chopchop/logic/commands/EditRecipeCommand.java 93.80% <0.00%> (-1.74%) 39.00 <0.00> (ø)
...java/chopchop/logic/edit/RecipeEditDescriptor.java 94.73% <ø> (ø) 11.00 <0.00> (ø)
...ava/chopchop/logic/autocomplete/AutoCompleter.java 96.28% <60.00%> (+0.03%) 125.00 <1.00> (+1.00)
.../chopchop/logic/edit/IngredientEditDescriptor.java 40.00% <75.00%> (-60.00%) 2.00 <2.00> (-10.00)
...pchop/logic/parser/commands/EditCommandParser.java 95.52% <76.00%> (-4.48%) 56.00 <8.00> (+4.00) :arrow_down:
...chopchop/logic/commands/EditIngredientCommand.java 86.95% <86.95%> (ø) 11.00 <11.00> (?)
...main/java/chopchop/logic/commands/HelpCommand.java 88.50% <100.00%> (ø) 19.00 <0.00> (ø)
...opchop/logic/edit/IngredientRefEditDescriptor.java 100.00% <100.00%> (ø) 12.00 <12.00> (?)
...hop/logic/parser/commands/DeleteCommandParser.java 100.00% <100.00%> (ø) 15.00 <0.00> (ø)
src/main/java/chopchop/ui/CommandBox.java 95.65% <100.00%> (+0.19%) 10.00 <0.00> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7767d0...6862370. Read the comment docs.

zhiayang commented 4 years ago

Will update the UG accordingly in #286