AY2021S1-CS2103T-W16-3 / tp

https://ay2021s1-cs2103t-w16-3.github.io/tp/
MIT License
0 stars 6 forks source link

Improve abstraction within classes related to bookmark transactions feature #291

Closed siddarth2824 closed 4 years ago

siddarth2824 commented 4 years ago

Resolves #290. Resolves #292, resolves #293.

Changes made:

codecov-io commented 4 years ago

Codecov Report

Merging #291 (b9be9e3) into master (d726aac) will increase coverage by 0.09%. The diff coverage is 93.98%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #291      +/-   ##
============================================
+ Coverage     88.04%   88.14%   +0.09%     
  Complexity      942      942              
============================================
  Files           119      117       -2     
  Lines          2343     2311      -32     
  Branches        325      318       -7     
============================================
- Hits           2063     2037      -26     
+ Misses          173      168       -5     
+ Partials        107      106       -1     
Impacted Files Coverage Δ Complexity Δ
...ic/commands/bookmark/AddBookmarkIncomeCommand.java 84.61% <ø> (ø) 7.00 <0.00> (ø)
..._3/finesse/model/bookmark/BookmarkTransaction.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
.../commands/bookmark/EditBookmarkExpenseCommand.java 86.66% <71.42%> (-1.22%) 8.00 <1.00> (-2.00)
...c/commands/bookmark/EditBookmarkIncomeCommand.java 86.66% <71.42%> (-1.22%) 8.00 <1.00> (-2.00)
...mmands/bookmark/ConvertBookmarkExpenseCommand.java 94.11% <83.33%> (-0.89%) 7.00 <1.00> (-1.00)
...ommands/bookmark/ConvertBookmarkIncomeCommand.java 94.11% <83.33%> (-0.89%) 7.00 <1.00> (-1.00)
..._cs2103_w16_3/finesse/logic/parser/ParserUtil.java 95.52% <92.00%> (-2.10%) 27.00 <9.00> (+10.00) :arrow_down:
...ogic/commands/bookmark/ConvertBookmarkCommand.java 100.00% <100.00%> (ø) 9.00 <9.00> (+8.00)
...logic/commands/bookmark/DeleteBookmarkCommand.java 100.00% <100.00%> (ø) 7.00 <7.00> (+6.00)
...ommands/bookmark/DeleteBookmarkExpenseCommand.java 100.00% <100.00%> (ø) 7.00 <1.00> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d726aac...b9be9e3. Read the comment docs.