search

AY2021S2-CS2103T-T10-1 / tp

https://ay2021s2-cs2103t-t10-1.github.io/tp/
MIT License
0 stars 6 forks source link

Fix regression that causes edit failure when name not edited #414

Closed kouyk closed 3 years ago

kouyk commented 3 years ago

The problem is with incomplete code change from the relaxation of conditions that determine if entities are the same. Switched to isSameAs from equals to resolve the issue.

codecov-io commented 3 years ago

Codecov Report

Merging #414 (89270c9) into master (91ac04c) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #414   +/-   ##
=========================================
  Coverage     60.79%   60.79%           
  Complexity      635      635           
=========================================
  Files           115      115           
  Lines          2395     2395           
  Branches        288      288           
=========================================
  Hits           1456     1456           
  Misses          819      819           
  Partials        120      120
Impacted Files Coverage Δ Complexity Δ
...ava/dog/pawbook/logic/commands/EditDogCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../dog/pawbook/logic/commands/EditEntityCommand.java 79.54% <0.00%> (ø) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91ac04c...89270c9. Read the comment docs.