search

AY2122S1-CS2103T-F12-2 / tp

https://ay2122s1-cs2103t-f12-2.github.io/tp/
MIT License
1 stars 5 forks source link

Fix Application Status colour regression, update UG/PlantUML/PPP, fix Select bug #207

Closed Chang-CH closed 3 years ago

Chang-CH commented 3 years ago

Issue introduced in #137.

Selection fix:

  1. added selectApplicant method in PersonListPanel to fire a select event in ListView.
  2. Modified handleView in MainWindow to call selectApplicant first.

Closes #160, #90, #188

codecov-commenter commented 3 years ago

Codecov Report

Merging #207 (30250e2) into master (89964fb) will decrease coverage by 0.11%. The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #207      +/-   ##
============================================
- Coverage     70.60%   70.49%   -0.12%     
  Complexity      593      593              
============================================
  Files            85       85              
  Lines          1919     1922       +3     
  Branches        259      259              
============================================
  Hits           1355     1355              
- Misses          445      448       +3     
  Partials        119      119
Impacted Files Coverage Δ
src/main/java/seedu/intern/ui/MainWindow.java 0.00% <0.00%> (ø)
...c/main/java/seedu/intern/ui/PersonDetailPanel.java 0.00% <ø> (ø)
src/main/java/seedu/intern/ui/PersonListPanel.java 0.00% <0.00%> (ø)
...eedu/intern/model/applicant/ApplicationStatus.java 85.29% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89964fb...30250e2. Read the comment docs.

yunpeng1234 commented 3 years ago

LGTM, can help check the UML picture on pr #216

Chang-CH commented 3 years ago

Review skipped with comment link

Merging since this is 4 days old already.